Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(meshexternalservice): support MeshExternalService in MeshGateway and MeshHTTPRoute #11383

Merged
merged 15 commits into from
Sep 13, 2024
Merged

feat(meshexternalservice): support MeshExternalService in MeshGateway and MeshHTTPRoute #11383

merged 15 commits into from
Sep 13, 2024

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Sep 11, 2024 •
edited
Loading

xrel #11325
xrel #11372

needs #11382

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@slonka slonka mentioned this pull request Sep 12, 2024
Open
@slonka slonka marked this pull request as ready for review September 13, 2024 07:59
@slonka slonka requested a review from a team as a code owner September 13, 2024 07:59
@slonka slonka requested review from jakubdyszkiewicz, lobkovilya, michaelbeaumont and lukidzi and removed request for a team September 13, 2024 07:59
@slonka slonka merged commit 52a287d into kumahq:master Sep 13, 2024
20 checks passed
@slonka slonka mentioned this pull request Sep 13, 2024
Open
@michaelbeaumont michaelbeaumont mentioned this pull request Sep 16, 2024
Closed
3 tasks
@jijiechen jijiechen changed the title feat(meshexternalservice): add support for MeshGateway + MeshHTTPRoute feat(meshexternalservice): support MeshExternalService in MeshGateway and MeshHTTPRoute Oct 11, 2024
@BrewTestBot BrewTestBot mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz jakubdyszkiewicz is a code owner automatically assigned from kumahq/kuma-maintainers

@lobkovilya lobkovilya Awaiting requested review from lobkovilya lobkovilya is a code owner automatically assigned from kumahq/kuma-maintainers

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slonka @lukidzi